Merge TunnelProviderMessaging into PacketTunnelCore #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pronebird
force-pushed
the
move-ipc-into-ptcore
branch
3 times, most recently
from
08cee3d to
02787f4
Compare
pronebird
force-pushed
the
move-ipc-into-ptcore
branch
2 times, most recently
from
94d5f46 to
4a39648
Compare
buggmagnet
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Reviewed 22 of 24 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
buggmagnet
force-pushed
the
move-ipc-into-ptcore
branch
from
4a39648 to
e98d440
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates TunnelProviderMessaging into PacketTunnelCore which now contains everything that concerns packet tunnel and interaction with it.
This change is